G goffi 24/08/2022, 08:19 Hi, first, thank you for your work. A few remarks: 1) aren't pylint and mypy overlapping? Note that I'm planning in a relatively short term to move to Poetry and pyproject.toml, thus it would be good to avoid adding too many configuration files which will have to be ported. I'm also not a big fan of the # pylint: … comments everywhere, but I can live with it in some plugins for now. 2) please use the same docstring convention as the rest of the code: Short description More information if needed @param param_name: doc @return: doc @raise exception: reason 3) why did you alias _ as i18n_untyped and D_ as deferred_i18n_untyped? The short name were choose on purpose as it makes the code more readable, and _ is the usual convention for gettext. Please keep original names. 4) regarding method name, Libervia use camelCase for method name due to the historic use of Twisted which does the same (PEP8 even says that we can keep original style in this case). However, I'm willing to move to snake_case (and some methods are already in snake_case). I'm not sure if the time is right to do that and if mixing both is a good idea right thing. Subject open to discussion. 5) the max line length used in Libervia is 90 chars, not 110, please update pylint and flake8 confs. Globally the style used is compatible with black, thus I'm not sure if flake8 is useful at all. 6) I'm not against a XEP-0082 plugin. However, the fact that a duplicate method exists can cause inconsistencies in datetime handling in plugins. Maybe is would make sense to rebase xmpp_date on your code and make XEP-0082 plugin a simple wrapper around it? Just wondering. 7) I see that you use "SAT" in comments (probably a copy-paste of other plugin. Following the renaming of the project, please use "Libervia" everywhere where it's possible now. You have also copy/paster my name on top of XEP-0420 implementation and other files (like tests), but it should be yours ;) 8) Doesn't xmlschema overlap with lxml? I'm wondering because a new dependency can always cause trouble for some platforms like Android or Web. If not, we'll deal with it. 9) It doesn't look right to have twisted/plugins/dropin.cache in the repos. Beside mostly those style things, your MR looks great, congrats.